Adjust notebooks and test code to allow for pytest testing #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Collaborator
Author
|
I have added the cleanup functionality for the checkpoints. In my local setup, the tests pass now, except for the error reported in #433. From my side, this is ready to be reviewed. |
LarsKue
requested changes
Apr 22, 2025
Contributor
LarsKue
left a comment
LarsKue
left a comment
There was a problem hiding this comment.
Looks great, thank you for the PR! Could you remove the unnecessary except block before merging?
Collaborator
Author
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LarsKue already added the infrastructure for this, but a few minor adjustments were still needed to make the tests pass.
I skipped the Notebook using Stan for now. Also missing is some clean-up, to remove stored checkpoints in the end. Opening this as a draft for now, and converting when those issues are dealt with.